add apollo query duration #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Jan 9, 2024
| let logger = ctx.context.log || graphqlLogger | ||
| if (ctx.context.apolloRequestStart) | ||
| logger = logger.child({ | ||
| 'apollo-query-duration': new Date() - ctx.context.apolloRequestStart |
There was a problem hiding this comment.
FYI: Typescript doesn't like subtracting dates. From what I recall, I think you need to call .getTime() and subtract that.
There was a problem hiding this comment.
I think Date.now() is what you're looking for
There was a problem hiding this comment.
i always forget that, thanks
iainsproat
reviewed
Jan 9, 2024
|
|
||
| if (ctx.request.transaction) { | ||
| ctx.request.transaction.finish() | ||
| } | ||
| logger.info('graphql response') |
There was a problem hiding this comment.
Ideally this should be unique so we can easily find the location in the code. We already log graphql response elsewhere.
iainsproat
requested changes
Jan 9, 2024
| const logger = ctx.context.log || graphqlLogger | ||
| logger.info('graphql response') | ||
| let logger = ctx.context.log || graphqlLogger | ||
| logger = logger.child() |
There was a problem hiding this comment.
why call child without any new properties?
| @@ -69,9 +73,15 @@ module.exports = { | |||
| (err instanceof GraphQLError && err.extensions?.code === 'FORBIDDEN') || | |||
| err instanceof ApolloError | |||
| ) { | |||
| logger.info(err, 'graphql error') | |||
| logger.info( | |||
| err, | |||
There was a problem hiding this comment.
for .info we need to wrap the error in an object e.g. {err}, I believe. Only .error wraps it automatically.
| @@ -18,6 +18,7 @@ const metricCallCount = new prometheusClient.Counter({ | |||
| module.exports = { | |||
| // eslint-disable-next-line no-unused-vars | |||
| requestDidStart(ctx) { | |||
| const apolloRequestStart = new Date() | |||
| @@ -56,6 +57,9 @@ module.exports = { | |||
| }, | |||
| didEncounterErrors(ctx) { | |||
| let logger = ctx.context.log || graphqlLogger | |||
| logger = logger.child({ | |||
| apollo_query_duration_ms: new Date() - apolloRequestStart | |||
|
|
||
| if (ctx.request.transaction) { | ||
| ctx.request.transaction.finish() | ||
| } | ||
| logger.info( | ||
| { | ||
| apollo_query_duration_ms: new Date() - apolloRequestStart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References