Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WBX-33] Add Keystrokes to Measure Mode #2033

Merged
merged 8 commits into from
Feb 16, 2024
Merged

[WBX-33] Add Keystrokes to Measure Mode #2033

merged 8 commits into from
Feb 16, 2024

Conversation

andrewwallacespeckle
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle commented Feb 10, 2024 •
edited
Loading

JIRA TICKET

Changes:

  • Add onKeyStroke (Escape) to Controls.vue. This will escape the active selected item. In the case of measure mode, this also cancels the in progress measurement
  • When Measure mode is active, pressing delete or backspace, will delete the in selected measurement

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review February 10, 2024 01:04
didimitrie
didimitrie previously approved these changes Feb 12, 2024
View reviewed changes
fabis94
fabis94 requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@andrewwallacespeckle andrewwallacespeckle merged commit 0b9a6ae into main Feb 16, 2024
19 of 22 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/WBX-33-Measurement-Keystrokes branch February 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

@didimitrie didimitrie didimitrie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewwallacespeckle @fabis94 @didimitrie