fix(helm chart): if .Values.server.mp.enabled is set to false, honour it #2073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
If
.Values.server.monitoring.mp.enabled
was set tofalse
(without quotations) thenENABLE_MP
was never set due to bug in helm chart logic. This PR makes it more robust, and will force the value to be quoted.Changes:
.Values.esrver.monitoring.mp.enabled
value, sofalse
is honouredENABLE_MP
totrue
if no value is provided, as the server itself controls the default value and this is duplicate.ENABLE_MP
for Docker Compose deployed by Tilt.To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References