Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm chart): if .Values.server.mp.enabled is set to false, honour it #2073

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Feb 23, 2024

Description & motivation

If .Values.server.monitoring.mp.enabled was set to false (without quotations) then ENABLE_MP was never set due to bug in helm chart logic. This PR makes it more robust, and will force the value to be quoted.

Changes:

  • quotes .Values.esrver.monitoring.mp.enabled value, so false is honoured
  • removes the defaulting of ENABLE_MP to true if no value is provided, as the server itself controls the default value and this is duplicate.
  • disables ENABLE_MP for Docker Compose deployed by Tilt.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review February 23, 2024 11:24
@iainsproat iainsproat merged commit 9dd1dde into main Feb 23, 2024
22 of 24 checks passed
@iainsproat iainsproat deleted the iain/enable-mp-by-default branch February 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant