Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): multi-region aware liveness and readiness checks #3468

Merged
merged 28 commits into from
Dec 11, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 8, 2024

Description & motivation

Determines if all databases are up and have sufficient free connections in the knex connection pool.
This informs the liveness and readiness checks.

Changes:

  • Separates the various components of the liveness and readiness checks into different files for readability
  • Adding a new region will add a new metric to the liveness and readiness endpoints

To-do before merge:

  • update the calculation of free connections when a region is added without incurring a restart of the app.
  • check if ServerInfo remains a valid test of whether the database connection is working

Screenshots:

Validation of changes:

Screenshot 2024-11-08 at 21 14 56 Screenshot 2024-11-08 at 21 15 03

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented Nov 8, 2024

@iainsproat iainsproat marked this pull request as ready for review November 18, 2024 16:18
@gjedlicska
Copy link
Contributor

@iainsproat tests are failing on this one

@iainsproat iainsproat merged commit 27a0600 into main Dec 11, 2024
26 of 28 checks passed
@iainsproat iainsproat deleted the iain/web-2142-multi-region-db-connection-health branch December 11, 2024 09:29
iainsproat added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants