feat(multi-region): metrics for knex for all regional databases #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add 'region' label
- this change collapses both into initialize, and adds checks to ensure initialization is done before being updated for new regions
gjedlicska
reviewed
Dec 11, 2024
| @@ -24,14 +24,14 @@ export default function (app: express.Express) { | |||
| register: prometheusClient.register, | |||
| collectionPeriodMilliseconds: highFrequencyMetricsCollectionPeriodMs(), | |||
| config: { | |||
| knex | |||
| getDbClients: getAllRegisteredDbClients | |||
There was a problem hiding this comment.
you could get all clients from the config and then this would not rely on any DB state.
There was a problem hiding this comment.
Do we want to get metrics for databases that are not yet registered and being used?
Especially if we start introducing alerting in the future around some of these metrics, we'd have alerts on potentially unused databases.
gjedlicska
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Part of https://linear.app/speckle/issue/WEB-2142/multi-region-db-connection-health
Metrics on knex queries and connection pools are gathered and made available as Prometheus metrics.
These are updated to gather data on all knex clients for all multi-region databases.
This PR updates the server component only; fileimport-service, preview-service, and webhook-service will be updated in later PRs
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References