Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(env vars): rename AUTOMATE_ENCRYPTION_KEYS_PATH with ENCRYPTION_KEYS_PATH #3616

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Dec 3, 2024

⚠️ This is a breaking change for all developers.

Please update from the .env.example file for speckle server, replacing AUTOMATE_ENCRYPTION_KEYS_PATH with ENCRYPTION_KEYS_PATH

Description & motivation

Encryption keys are used for SSO feature, not only an automate feature. The environment variable should be added if either feature flag is enabled.

The environment variable name is updated to reflect this change. The helm chart template logic is revised to enable this environment variable for either feature flag.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat changed the title refactor(env vars): rename AUTOMATE_ENCRTYPTION_KEYS_PATH with ENCRYP… refactor(env vars): rename AUTOMATE_ENCRTYPTION_KEYS_PATH with ENCRYPTION_KEYS_PATH Dec 3, 2024
@iainsproat iainsproat requested a review from gjedlicska December 3, 2024 15:47
@iainsproat iainsproat marked this pull request as ready for review December 3, 2024 15:47
@iainsproat iainsproat requested a review from cdriesler December 3, 2024 16:40
@iainsproat iainsproat changed the title refactor(env vars): rename AUTOMATE_ENCRTYPTION_KEYS_PATH with ENCRYPTION_KEYS_PATH refactor(env vars): rename AUTOMATE_ENCRYPTION_KEYS_PATH with ENCRYPTION_KEYS_PATH Dec 3, 2024
@iainsproat iainsproat merged commit cdf9c48 into main Dec 4, 2024
26 of 28 checks passed
@iainsproat iainsproat deleted the iain/rename-encryption-keys-path branch December 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants