fix(automate): redirect github auth flow to workspace if possible #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
previously approved these changes
Dec 4, 2024
cdriesler
requested review from
Mikehrn and
andrewwallacespeckle
and removed request for
gjedlicska
fabis94
requested changes
Dec 5, 2024
| @@ -77,7 +80,7 @@ const props = defineProps<{ | |||
| isAuthorized: boolean | |||
| templates: CreatableFunctionTemplate[] | |||
| githubOrgs: string[] | |||
| workspaceId?: string | |||
| workspace?: Pick<Workspace, 'id' | 'slug'> | |||
There was a problem hiding this comment.
fabis94
previously approved these changes
Dec 5, 2024
| import type { AutomateFunctionEditDialog_WorkspaceFragment } from '~/lib/common/generated/gql/graphql' | ||
|
|
||
| graphql(` | ||
| fragment AutomateFunctionEditDialog_Workspace on Workspace { |
There was a problem hiding this comment.
I don't see this one used in other fragments or queries
fabis94
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
/functionsin all casesChanges:
workspaceSlugin request session if available/workspaces/:slug/functionsat end if value is available (preserving the private function creation flow)Validated with a personal github app locally, may be difficult to test (can help)