Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(server): event bus refactor - access req emitter - batch #3 #3769

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore(server): event bus refactor - access req emitter - batch #3 #3769

merged 1 commit into from
Jan 13, 2025

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Jan 7, 2025

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@linear Linear
Copy link

linear bot commented Jan 7, 2025

WEB-2414 Replace module-scoped event buses with the global one

gjedlicska
gjedlicska previously approved these changes Jan 8, 2025
View reviewed changes
@fabis94 fabis94 force-pushed the fabians/web-2414-2 branch from cfe9d9f to dab0a23 Compare January 13, 2025 09:03
@fabis94 fabis94 force-pushed the fabians/web-2414-3 branch from 73950cc to 0b81f99 Compare January 13, 2025 09:04
Base automatically changed from fabians/web-2414-2 to main January 13, 2025 10:39
@fabis94 fabis94 dismissed gjedlicska’s stale review January 13, 2025 10:39

The base branch was changed.

@fabis94 fabis94 requested a review from gjedlicska January 13, 2025 10:39
@fabis94 fabis94 merged commit ee168d6 into main Jan 13, 2025
26 of 28 checks passed
@fabis94 fabis94 deleted the fabians/web-2414-3 branch January 13, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemagio alemagio alemagio approved these changes

@iainsproat iainsproat Awaiting requested review from iainsproat

@cdriesler cdriesler Awaiting requested review from cdriesler

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabis94 @alemagio @gjedlicska