Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add curve to direct shape conversions #37

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Conversation

connorivy
Copy link
Contributor

@connorivy connorivy commented Jul 16, 2024

Description & motivation

Changes:

Adds a top level converter for each ICurve implementation. I think it has to be done this way since our conversions our found by the name of the type as opposed to the actual type with implemented interface information.

To-do before merge:

Screenshots:

image

Curves are imported correctly as direct shapes

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 5.65%. Comparing base (f4a542b) to head (d2c5fe7).

Files Patch % Lines
...rectShape/CurveToDirectShapeConverterToHostBase.cs 0.00% 21 Missing ⚠️
...l/ToDirectShape/ArcToDirectShapeConverterToHost.cs 0.00% 1 Missing ⚠️
...oDirectShape/CircleToDirectShapeConverterToHost.cs 0.00% 1 Missing ⚠️
...ToDirectShape/CurveToDirectShapeConverterToHost.cs 0.00% 1 Missing ⚠️
...DirectShape/EllipseToDirectShapeConverterToHost.cs 0.00% 1 Missing ⚠️
.../ToDirectShape/LineToDirectShapeConverterToHost.cs 0.00% 1 Missing ⚠️
...TopLevel/ToDirectShape/PolycurveConverterToHost.cs 0.00% 1 Missing ⚠️
.../TopLevel/ToDirectShape/PolylineConverterToHost.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev     #37      +/-   ##
========================================
- Coverage   5.69%   5.65%   -0.05%     
========================================
  Files        169     177       +8     
  Lines       3476    3504      +28     
  Branches     424     425       +1     
========================================
  Hits         198     198              
- Misses      3275    3303      +28     
  Partials       3       3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorivy
Copy link
Contributor Author

@adamhathcock the build is failing due to xml comments that haven't been updated. Old xml comments that this pr doesn't touch. Do you know why this is happening?

@adamhathcock
Copy link
Member

XML comment restrictions got turned on. I've got like 3 PRs with the same issue. I'll fix yours and merge it

@connorivy connorivy merged commit f6ae5ea into dev Jul 19, 2024
6 checks passed
@connorivy connorivy deleted the DUI3-475-DirectShape-Curves branch July 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants