-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add curve to direct shape conversions #37
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #37 +/- ##
========================================
- Coverage 5.69% 5.65% -0.05%
========================================
Files 169 177 +8
Lines 3476 3504 +28
Branches 424 425 +1
========================================
Hits 198 198
- Misses 3275 3303 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
...nverters.RevitShared/ToHost/TopLevel/ToDirectShape/ICurveToDirectShapeConverterToHostBase.cs
Outdated
Show resolved
Hide resolved
@adamhathcock the build is failing due to xml comments that haven't been updated. Old xml comments that this pr doesn't touch. Do you know why this is happening? |
XML comment restrictions got turned on. I've got like 3 PRs with the same issue. I'll fix yours and merge it |
Description & motivation
Changes:
Adds a top level converter for each ICurve implementation. I think it has to be done this way since our conversions our found by the name of the type as opposed to the actual type with implemented interface information.
To-do before merge:
Screenshots:
Curves are imported correctly as direct shapes
Validation of changes:
Checklist:
References