Introduce Event aggregator #417
Merged
+1,315
−414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
requested changes
Jan 20, 2025
| @@ -1,49 +1,46 @@ | |||
| using Speckle.Connectors.DUI.Bindings; | |||
| using Speckle.Connectors.DUI.Bridge; | |||
| using Speckle.Connectors.DUI.Eventing; | |||
| using Speckle.Connectors.RhinoShared; | |||
There was a problem hiding this comment.
Why do we importing from RhinoShared in Tekla?
There was a problem hiding this comment.
The events were declared in the wrong namespace but fixed in another PR: b5871d5
|
Probably done at the same time: #505 |
* Support async publish but async or sync subscribe * Publish with tests * more sub overloads * added onetime tests that fail * Reorganized events to have async and sync * adjust subscriptions * Rhino fixes * use async eventing everywhere and add docstore init method * clean up * add handlers for unobserved task exceptions * fix usage of exception handler to include one time users * fix(civil3d): handles property exceptions for corridor elements (#508) * Update GeneralPropertiesExtractor.cs * Update GeneralPropertiesExtractor.cs * Update CorridorDisplayValueExtractor.cs * Fix weak references * Fix TeklaEvents namespace * Anonymous methods are always created as strong references * refactor to have features --------- Co-authored-by: Claire Kuang <[email protected]>
JR-Morgan
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/speckle/Event-Aggregation-174b78fc7aa6806a86e7f451fa7c4b96
Decouples exception handler from browser bridge.
IdleManager is now a OneTime event with IDs.
Rhino is converted.
Global Events (Doc changed) are converted.
More events to come!