Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellationmanager revamp #527

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Conversation

adamhathcock
Copy link
Member

Cancellation manager shouldn't dispose when cancelling
Force removal when send/receive is done

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Project coverage is 18.79%. Comparing base (184c53c) to head (83ea845).

Files with missing lines Patch % Lines
...nectors.Common/Cancellation/CancellationManager.cs 90.90% 0 Missing and 1 partial ⚠️
...Speckle.Connectors.Common/ContainerRegistration.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #527      +/-   ##
==========================================
+ Coverage   17.31%   18.79%   +1.48%     
==========================================
  Files         239      240       +1     
  Lines        4818     4883      +65     
  Branches      579      579              
==========================================
+ Hits          834      918      +84     
+ Misses       3954     3934      -20     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock enabled auto-merge (squash) January 30, 2025 14:11
@clairekuang clairekuang self-requested a review January 31, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant