Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeriodicThreadedEvent to EA and use it #530

Merged

Conversation

adamhathcock
Copy link
Member

Used in ETABs and Revit 2022

Copy link

linear bot commented Jan 28, 2025

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.35%. Comparing base (03f0b1f) to head (e23fcb8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #530      +/-   ##
==========================================
+ Coverage   15.86%   17.35%   +1.48%     
==========================================
  Files         238      239       +1     
  Lines        4720     4805      +85     
  Branches      578      579       +1     
==========================================
+ Hits          749      834      +85     
  Misses       3941     3941              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernsteinhagen
Copy link
Contributor

Testing on Etabs now :)

@bjoernsteinhagen
Copy link
Contributor

bjoernsteinhagen commented Jan 28, 2025

Tested:

  • Open Etabs model -> select objects -> change selection -> updated selection from GetSelection?
  • Open Etabs model -> send model -> close plugin -> re-open and observe model cards
  • Open Etabs model -> open Speckle plugin -> close Speckle plugin -> change models (required fix from bjorn/cnx-1118-model-cards-and-opening-multiple-files-from-the-same-folder #533)
  • Open Etabs model -> open Speckle plugin -> change model -> UI refreshed?

Links:

@adamhathcock
Copy link
Member Author

thanks!

@adamhathcock adamhathcock merged commit 9219cdf into dev Jan 29, 2025
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-160-rework-timers-to-go-via-event-aggregator branch January 29, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants