fixes #144 & #116 #242
Annotations
9 errors and 7 warnings
build (macos-latest)
ENOENT: no such file or directory, opendir '/Users/runner/work/specta/specta/target/tests/target'
|
build (macos-latest)
Error: ENOENT: no such file or directory, opendir '/Users/runner/work/specta/specta/target/tests/target'
|
build (macos-latest)
Process completed with exit code 101.
|
build (windows-latest)
The job was canceled because "macos-latest" failed.
|
build (windows-latest)
The operation was canceled.
|
build (windows-latest)
ENOENT: no such file or directory, opendir 'D:\a\specta\specta\target\tests\target'
|
build (windows-latest)
Error: ENOENT: no such file or directory, opendir 'D:\a\specta\specta\target\tests\target'
|
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
|
build (ubuntu-latest)
The operation was canceled.
|
length comparison to zero:
src/serde.rs#L164
warning: length comparison to zero
--> src/serde.rs:164:31
|
164 | if valid_variants == 0 && e.variants().len() != 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!e.variants().is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
single-character string constant used as pattern:
src/lang/js_doc.rs#L40
warning: single-character string constant used as pattern
--> src/lang/js_doc.rs:40:20
|
40 | .split("\n")
| ^^^^ help: try using a `char` instead: `'\n'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::all)]`
|
called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent:
src/lang/ts/mod.rs#L624
warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
--> src/lang/ts/mod.rs:624:31
|
624 | if let Some(first_char) = ident.chars().nth(0) {
| ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ident.chars().next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
= note: `#[warn(clippy::iter_nth_zero)]` implied by `#[warn(clippy::all)]`
|
length comparison to zero:
src/lang/ts/mod.rs#L426
warning: length comparison to zero
--> src/lang/ts/mod.rs:426:24
|
426 | if obj.fields.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `obj.fields.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` implied by `#[warn(clippy::all)]`
|
using a reference to `Cow` is not recommended:
src/lang/ts/mod.rs#L100
warning: using a reference to `Cow` is not recommended
--> src/lang/ts/mod.rs:100:44
|
100 | fn inner_comments(ctx: ExportContext, doc: &Cow<'static, str>, other: String) -> String {
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
note: the lint level is defined here
--> src/lib.rs:3:9
|
3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs
| ^^^^^^^^^^^
= note: `#[warn(clippy::ptr_arg)]` implied by `#[warn(clippy::all)]`
|
constant `RESERVED_IDENTS` is never used:
src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used
--> src/lang/ts/reserved_terms.rs:66:18
|
66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|