Skip to content

better-js-doc

better-js-doc #250

Triggered via push October 4, 2023 06:18
Status Success
Total duration 7m 49s
Artifacts

ci.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
length comparison to zero: src/serde.rs#L164
warning: length comparison to zero --> src/serde.rs:164:31 | 164 | if valid_variants == 0 && e.variants().len() != 0 { | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!e.variants().is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
calling `push_str()` using a single-character string literal: src/lang/js_doc.rs#L70
warning: calling `push_str()` using a single-character string literal --> src/lang/js_doc.rs:70:9 | 70 | self.value.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.value.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `#[warn(clippy::single_char_add_str)]` implied by `#[warn(clippy::all)]`
called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent: src/lang/ts/mod.rs#L629
warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent --> src/lang/ts/mod.rs:629:31 | 629 | if let Some(first_char) = ident.chars().nth(0) { | ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ident.chars().next()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero = note: `#[warn(clippy::iter_nth_zero)]` implied by `#[warn(clippy::all)]`
length comparison to zero: src/lang/ts/mod.rs#L427
warning: length comparison to zero --> src/lang/ts/mod.rs:427:24 | 427 | if obj.fields.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `obj.fields.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` implied by `#[warn(clippy::all)]`
using a reference to `Cow` is not recommended: src/lang/ts/mod.rs#L103
warning: using a reference to `Cow` is not recommended --> src/lang/ts/mod.rs:103:11 | 103 | docs: &Cow<'static, str>, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` implied by `#[warn(clippy::all)]`
this expression creates a reference which is immediately dereferenced by the compiler: src/lang/ts/comments.rs#L21
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/lang/ts/comments.rs:21:33 | 21 | builder.push_deprecated(&deprecated); | ^^^^^^^^^^^ help: change this to: `deprecated` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow note: the lint level is defined here --> src/lib.rs:3:9 | 3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
constant `RESERVED_IDENTS` is never used: src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used --> src/lang/ts/reserved_terms.rs:66:18 | 66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[ | ^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/