Cleanup type collection #381
Annotations
5 errors and 14 warnings
build (macos-latest)
Process completed with exit code 101.
|
build (windows-latest)
The job was canceled because "macos-latest" failed.
|
build (windows-latest)
The operation was canceled.
|
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
|
build (ubuntu-latest)
The operation was canceled.
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/type_collection.rs#L39
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/type_collection.rs:39:29
|
39 | let dt = export(&mut type_map);
| ^^^^^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
|
this `impl` can be derived:
src/type_collection.rs#L14
warning: this `impl` can be derived
--> src/type_collection.rs:14:1
|
14 | / impl Default for TypeCollection {
15 | | fn default() -> Self {
16 | | Self {
17 | | types: HashMap::new(),
18 | | }
19 | | }
20 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]`
= help: remove the manual implementation...
help: ...and instead derive it
|
10 + #[derive(Default)]
11 | pub struct TypeCollection {
|
|
accessing first element with `generics.get(0)`:
src/type/impls.rs#L165
warning: accessing first element with `generics.get(0)`
--> src/type/impls.rs:165:17
|
165 | / generics
166 | | .get(0)
| |___________________________^ help: try: `generics.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `generics.get(0)`:
src/type/impls.rs#L153
warning: accessing first element with `generics.get(0)`
--> src/type/impls.rs:153:18
|
153 | ty = generics.get(0).cloned()
| ^^^^^^^^^^^^^^^ help: try: `generics.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` implied by `#[warn(clippy::all)]`
|
calling `push_str()` using a single-character string literal:
src/lang/ts/mod.rs#L166
warning: calling `push_str()` using a single-character string literal
--> src/lang/ts/mod.rs:166:5
|
166 | s.push_str(";");
| ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(';')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
|
calling `push_str()` using a single-character string literal:
src/lang/ts/mod.rs#L159
warning: calling `push_str()` using a single-character string literal
--> src/lang/ts/mod.rs:159:5
|
159 | s.push_str(")");
| ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(')')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
|
calling `push_str()` using a single-character string literal:
src/lang/ts/mod.rs#L149
warning: calling `push_str()` using a single-character string literal
--> src/lang/ts/mod.rs:149:5
|
149 | s.push_str("(");
| ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('(')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` implied by `#[warn(clippy::all)]`
|
this function has too many arguments (8/7):
src/internal.rs#L229
warning: this function has too many arguments (8/7)
--> src/internal.rs:229:5
|
229 | / pub fn get_fn_datatype<TMarker, T: Function<TMarker>>(
230 | | _: T,
231 | | asyncness: bool,
232 | | name: Cow<'static, str>,
... |
237 | | no_return_type: bool,
238 | | ) -> FunctionDataType {
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
note: the lint level is defined here
--> src/lib.rs:3:9
|
3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs
| ^^^^^^^^^^^
= note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]`
|
constant `RESERVED_IDENTS` is never used:
src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used
--> src/lang/ts/reserved_terms.rs:66:18
|
66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[
| ^^^^^^^^^^^^^^^
|
field `0` is never read:
src/lang/ts/context.rs#L10
warning: field `0` is never read
--> src/lang/ts/context.rs:10:18
|
10 | TypeExtended(Cow<'static, str>, ImplLocation),
| ------------ ^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
10 | TypeExtended((), ImplLocation),
| ~~
|
unused import: `selection::*`:
src/lib.rs#L37
warning: unused import: `selection::*`
--> src/lib.rs:37:9
|
37 | pub use selection::*;
| ^^^^^^^^^^^^
|
unused import: `Cow`:
src/type_collection.rs#L2
warning: unused import: `Cow`
--> src/type_collection.rs:2:22
|
2 | borrow::{Borrow, Cow},
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|