Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a content validator #138

Closed
DylanBaker opened this issue Nov 25, 2019 · 1 comment · Fixed by #236
Closed

Add a content validator #138

DylanBaker opened this issue Nov 25, 2019 · 1 comment · Fixed by #236
Assignees
Labels

Comments

@DylanBaker
Copy link
Collaborator

DylanBaker commented Nov 25, 2019

Spectacles users would benefit from an additional validator that runs Looker's Content Validation via the API. There are a number of open questions about how this should work. This validator could expose the output in two possible ways:

  • All content that requires validating on that branch. This would be a simple call to the content validation endpoint.
  • All content that requires validating on that branch that doesn't require validating on the master branch, i.e. things that this branch actually broke. This would require two calls and comparison of content between the two.

My gut feel is that we probably want to provide both ways, possibly controlled by a flag.

@joshtemple joshtemple added the Question Further information is requested label Nov 27, 2019
@DylanBaker DylanBaker added this to the 0.2.0 milestone Dec 2, 2019
@DylanBaker DylanBaker removed this from the 0.2.0 milestone Mar 23, 2020
@joshtemple
Copy link
Collaborator

Adding some more questions to be answered:

  1. What should people be able to select or exclude? Folders? Spaces? Anything in a private space?

  2. How should the content be grouped? In Looker you can change this to group on error, folder, or content. Should we provide an option in the CLI to do the same or is this superfluous?

@joshtemple joshtemple added Enhancement New feature or request and removed Question Further information is requested labels Jun 9, 2020
@joshtemple joshtemple changed the title Content Validation: What should we report? Add a validator to validate Looker content Jun 9, 2020
@joshtemple joshtemple self-assigned this Jun 9, 2020
@joshtemple joshtemple added the Epic label Jun 9, 2020
@joshtemple joshtemple changed the title Add a validator to validate Looker content Add a content validator Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants