-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log failing SQL to file #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtemple
reviewed
Apr 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 70.70% 70.66% -0.05%
==========================================
Files 10 10
Lines 809 818 +9
==========================================
+ Hits 572 578 +6
- Misses 237 240 +3
Continue to review full report at Codecov.
|
joshtemple
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84
This PR grabs the
sql
variable on theSqlError
and logs the query to the logs and to a file in the logs directory.Initially, I wrote it that the
log_failing_sql
function didn't take a directory, and just used theLOG_DIRECTORY
global variable. I was having some difficulty getting the tests to work though as I couldn't seem to overwrite that variable and log the queries to a temp directory. Very open to feedback/advise on how to improve that.