Allow store_true action with environment variables
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanBaker
approved these changes
Apr 29, 2020
DylanBaker
added a commit
that referenced
this pull request
Apr 29, 2020
* laying out decorator structure * get_dependent_projects * refactored to move logic into runner * add manifest dependency argument to CLI * fixed test_bad_request_raises_connection_error to include new methods * more tests * cleanup test_runner file * update rebase: * pass self to wrapper * static method * temp ignore decorator: * move decorator outside runner class * moving runner logic out of client + changes to decorator * fixed tests * renamed manifest dependency * add update branch method * updated tests * added EnvVarAction to import projects * Allow import-projects to be set via an environment variable (#187) * add import-prjects to assert: Co-authored-by: Josh Temple <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of hack (subclasses a private argparse action), but allows the behavior we would like.
Can set
SPECTACLES_IMPORT_PROJECTSto case-insensitiveTrueorFalse, otherwise the--import-projectsCLI flag works without an option being provided. Setting the option with atrueorfalsein the YAML file still works as well.