Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log with UTF-8 to file #225

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Log with UTF-8 to file #225

merged 1 commit into from
Jun 11, 2020

Conversation

joshtemple
Copy link
Collaborator

Solves an issue with Unicode encoding errors in the FileHandler of the Spectacles logger.

@joshtemple joshtemple requested a review from DylanBaker as a code owner June 11, 2020 13:52
@joshtemple joshtemple merged commit e500c92 into master Jun 11, 2020
@joshtemple joshtemple deleted the hotfix/windows-logging-utf8 branch September 1, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanBaker DylanBaker DylanBaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshtemple @DylanBaker