Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore ~/.netrc entries when authenticating to looker api #281

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

roulettedares
Copy link
Contributor

@roulettedares roulettedares commented Aug 12, 2020

i had an older looker api entry in ~/.netrc which was causing me authentication headaches. this PR effectively ignores ~/.netrc entries for looker api. the official looker SDK does this as well https://github.com/looker-open-source/sdk-codegen/blob/master/python/looker_sdk/rtl/requests_transport.py#L77

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #281 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   91.97%   92.00%   +0.02%     
==========================================
  Files          17       17              
  Lines        1196     1200       +4     
==========================================
+ Hits         1100     1104       +4     
  Misses         96       96              
Impacted Files Coverage Δ
spectacles/client.py 98.76% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5e1b2...d7e511c. Read the comment docs.

Copy link
Collaborator

@joshtemple joshtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little wary of breaking support for credentials in .netrc files, but since it's never been something we've explicitly supported and since we already have a built in config file for Spectacles, I'm happy to merge this.

@joshtemple joshtemple merged commit 616fffd into spectacles-ci:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants