Data tests can cause "user query limit" issue if queries queue for over 600 seconds. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanBaker
changed the title
joshtemple
reviewed
Jan 3, 2023
There was a problem hiding this comment.
This looks good!
I wonder, should we set the SQL validator's query concurrency to 15 by default as well? If Looker is capping the per-user query concurrency at 15, I'm not sure it makes sense to allow users to set concurrency any higher, or even to configure that value. From my testing with async, I struggled to get 20+ queries running simultaneously anyway.
spectacles/validators/data_test.py
Outdated
| }, | ||
| } | ||
| query_slot = asyncio.Semaphore( | ||
| 15 |
There was a problem hiding this comment.
Let's define this 15 as a constant at the top of the module.
joshtemple
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
With the recent async changes, we now run all data tests at the same time.
This is from the Looker docs:
Some organisaitons have a large number of tests, many of which take a while to run. As a result of this, some organisations are getting errors related to the user query limit when the data test queries take a long time.
This PR sets a concurrency limit of 15 to the data tests.
Type of change
Related issues
Closes #671
Checklists
Security
Code review