Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset skip_imports when exiting branch manager #675

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

DylanBaker
Copy link
Collaborator

Change description

This change resets skip_imports on the branch manager to an empty list, in the __aexit__ function. This means that imports will be resolved for each use of the branch manager, which is the intended behaviour.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Closes #674

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@DylanBaker DylanBaker requested a review from joshtemple as a code owner January 6, 2023 12:04
@DylanBaker DylanBaker merged commit e7f7899 into master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue with project imports in SQL incremental mode
2 participants