Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap retries from httpcore exception to httpx exception for RemoteProtocolError #714

Merged
merged 1 commit into from
May 23, 2023
Merged

Swap retries from httpcore exception to httpx exception for RemoteProtocolError #714

merged 1 commit into from
May 23, 2023

Conversation

DylanBaker
Copy link
Collaborator

Change description

When we set up retries for RemoteProtocolError in the client, we set it to retry on the exception from httpcore not httpx. In reality, it is the latter that is being raised. This change swaps this.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@DylanBaker DylanBaker requested a review from joshtemple as a code owner May 23, 2023 09:41
@DylanBaker DylanBaker merged commit 07e54b4 into master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtemple joshtemple joshtemple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanBaker @joshtemple