Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Explores without dimensions #715

Merged
merged 9 commits into from
May 24, 2023

Conversation

joshtemple
Copy link
Collaborator

@joshtemple joshtemple commented May 23, 2023

Change description

This change modifies Spectacles SQL validation behavior from raising an exception on Explores with zero dimensions to instead logging a warning and marking the Explore as skipped.

Here's an example of the output. Note the warning log and the improvement in the "Testing" header, as well as eye_exam.users__no_dims being marked as skipped with a reason for skipping.

(spectacles) ➜ spectacles sql --project eye_exam --branch dev-josh-temple-8m75 --incremental
Connected to Looker version 23.6.53 using Looker API 4.0
Warning: Explore 'users__no_dims' does not have any non-ignored dimensions and will not be validated.

=================== Testing 2/5 explores [concurrency = 10] ====================

✓ eye_exam.users passed
✓ eye_exam.users__fail skipped (unmodified)
✓ eye_exam.users__fail_and_warn skipped (unmodified)
✓ eye_exam.users__no_dims skipped (no dimensions)
✓ eye_exam.users__warn passed

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Improvement

Checklists

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@joshtemple joshtemple requested a review from DylanBaker as a code owner May 23, 2023 17:39
@joshtemple joshtemple merged commit 3409434 into master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants