Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This change modifies Spectacles SQL validation behavior from raising an exception on Explores with zero dimensions to instead logging a warning and marking the Explore as skipped.
Here's an example of the output. Note the warning log and the improvement in the "Testing" header, as well as
eye_exam.users__no_dims
being marked asskipped
with a reason for skipping.Type of change
Checklists
Security
Code review