Remove condition on server #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After studying the functionality of this code, I believe that the condition inside the server page to check if the input_msg contains new inputs, it is not necessary. The server will never receive a new server_input_msgs without new inputs, because these are sent by the client in each physical execution and detection of new inputs. PS: Congratulations on your code, it's excellent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spectre1989
After studying the functionality of this code, I believe that the condition inside the server page to check if the input_msg contains new inputs, it is not necessary.
The server will never receive a new server_input_msgs without new inputs, because these are sent by the client in each physical execution and detection of new inputs.
PS: Congratulations on your code, it's excellent