-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support custom max value for barcharts #545
Merged
patriksvensson
merged 3 commits into
spectreconsole:main
from
rifatx:feature/barchart-custom-max-value
Oct 4, 2021
Merged
Add support custom max value for barcharts #545
patriksvensson
merged 3 commits into
spectreconsole:main
from
rifatx:feature/barchart-custom-max-value
Oct 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriksvensson
requested changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from a minor thing 👍
patriksvensson
requested changes
Sep 27, 2021
patriksvensson
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
patriksvensson
approved these changes
Oct 4, 2021
Merged! Thank you for your contribution. Much appreciated! 👍 |
This was referenced Oct 5, 2021
This was referenced Oct 12, 2021
1 task
This was referenced Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, it will be possible to set a custom max value for barcharts, so that multiple charts could be visually aligned.
This PR closes issue #524.