-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates asciinema update #648
Merged
patriksvensson
merged 3 commits into
spectreconsole:main
from
phil-scott-78:asciinema-update
Dec 1, 2021
Merged
Updates asciinema update #648
patriksvensson
merged 3 commits into
spectreconsole:main
from
phil-scott-78:asciinema-update
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates playwright to latest version. This requires an update in how it is ran as part of the statiq build set up to ensure dependencies exist for the run. Also brings misc packages up to date to fix vulnerabilities.
I went ahead and updated the CI scripts to use node v16, the current LTS, so I didn't accidently update the package.json lock file to v2 again and break the build |
opps, and it looks like playwright now also need .net core 5 installed. hmmm. i'll mess with it in a bit |
phil-scott-78
force-pushed
the
asciinema-update
branch
from
December 1, 2021 02:40
05c8347
to
3aaf1e7
Compare
Playwright CLI currently needs net5 to execute. There is a PR in the works to get it running on net6 but until then the recommended steps it to have both installed.
phil-scott-78
force-pushed
the
asciinema-update
branch
from
December 1, 2021 02:47
3aaf1e7
to
88075d0
Compare
nils-a
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
patriksvensson
approved these changes
Dec 1, 2021
This was referenced Mar 27, 2022
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the newest asciienama player. While I was in here I went ahead and updated some JS dependencies that'll hopefully hush dependabot.