Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mask for secret #970

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Custom mask for secret #970

merged 8 commits into from
Sep 26, 2022

Conversation

GaryMcD
Copy link
Contributor

@GaryMcD GaryMcD commented Sep 18, 2022

Implemented functionality for #943.

  • Added char? to text prompt to hold character used for masking secrets.
  • Added string extension to replace each char in string with mask.
  • Replaced all hardcoded asterisks for secrets with new mask.

@GaryMcD
Copy link
Contributor Author

GaryMcD commented Sep 18, 2022

Next step is to create tests, and docs.

@GaryMcD
Copy link
Contributor Author

GaryMcD commented Sep 18, 2022

Tests have been created... but I am not sure how to run the tests on my local machine. @patriksvensson are you able to explain that or point me to some docs?

@GaryMcD
Copy link
Contributor Author

GaryMcD commented Sep 18, 2022

This should be good to go, if I can just figure out how to run tests locally.

@GaryMcD GaryMcD marked this pull request as ready for review September 18, 2022 03:11
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@patriksvensson patriksvensson merged commit eb02c3d into spectreconsole:main Sep 26, 2022
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants