chore(ci): use golangci-lint-action #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/cli [deprecated]
umarcor
reviewed
Sep 10, 2021
umarcor
reviewed
Sep 10, 2021
umarcor
reviewed
Sep 10, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
github-actions
bot
removed
the
area/cli [deprecated]
|
This PR is being marked as stale due to a long period of inactivity |
Closed
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 11, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 15, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 16, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
stmcginnis
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
I know there are some linters that don't work well with go 1.17 that get pulled in with golangci-lint prior to the 1.43.0 release. I wonder if we should add some sort of check to the makefile for that.
The action config is pulling in the latest golangci-lint, so that should work fine. And the change mentioned above isn't really in the scope of this PR, just thought I would mention it here in case someone has an old version on their system and runs into a problem because of it.
This change looks good to me.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 25, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 25, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Matthieu MOREL <[email protected]>
jpmcb
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to use golangci-lint-action instead of direct download of it's executable.
It allows also to see the tool's reviews outside of the logs in github.
I also formated and fixed the actual reviews.
Some linters were deprecated, so I used there actual versions