-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usability of Sphinx Lint with pre-commit #94
Conversation
Co-authored-by: Hugo van Kemenade <[email protected]>
Shall we release this? As a minor or patch? |
Could do a minor release! (Not sure it qualifies for a patch release since it's not fixing a regression, really, and there's a small risk that changing the defaults here could itself introduce regressions for users?) I think it's a useful change. It's also not a crucial change, though, so we could also wait for #87 to be ready. I'm easy either way :) |
Actually, I changed my mind. You're right, this probably does deserve a release on its own. As things stand, the advice in the README on how to use Sphinx Lint with pre-commit is now incorrect if you're using the latest release of Sphinx Lint :) Do you want to take care of the release, or shall I? |
Go for it! Will be a good test of trusted publishing and the release checklist: https://github.com/sphinx-contrib/sphinx-lint#releasing |
See #90 (comment)