Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling for errors in pre-build commands #181

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Improve handling for errors in pre-build commands #181

merged 1 commit into from
Oct 2, 2024

Conversation

AA-Turner
Copy link
Member

Closes #158

A

@AA-Turner AA-Turner requested a review from pradyunsg October 2, 2024 17:26
pradyunsg
pradyunsg approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to also eventually add an alert or similar via the websocket for these errors, but we can make that improvement in a follow up separately. :)

@AA-Turner AA-Turner merged commit 1771311 into sphinx-doc:main Oct 2, 2024
6 checks passed
@AA-Turner AA-Turner deleted the suffer-pre-build-failures branch October 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server stops rebuilding on changes if the pre-build step fails
2 participants
@AA-Turner @pradyunsg