Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgmath: Fix embed mode #10869

Closed
wants to merge 1 commit into from

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Sep 26, 2022

fixes #10816 on a bit more complex example

@jschueller jschueller force-pushed the math_embed_parallel branch 2 times, most recently from 69588d5 to 0bc2e3d Compare September 26, 2022 15:38
@jschueller jschueller changed the title Add testcase for imgmath_embed + parallel imgmath: Fix embed mode Sep 26, 2022
@jschueller jschueller marked this pull request as draft September 27, 2022 06:31
@AA-Turner AA-Turner marked this pull request as ready for review September 27, 2022 17:10
@AA-Turner
Copy link
Member

Is this alright to merge?

A

@jschueller jschueller marked this pull request as draft September 27, 2022 17:51
We incorrectly used leftover files from previous tests in the destination folder
instead of the temporary file we just generated.
@jschueller jschueller marked this pull request as ready for review September 28, 2022 09:19
@jschueller jschueller closed this Sep 28, 2022
@jschueller jschueller deleted the math_embed_parallel branch September 28, 2022 09:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants