Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linting] cleanup: remove commented-out mypy override filenames. #12171

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Cleanup

Purpose

Detail

  • Remove commented-out entries from the tool.mypy.overrides module list.

Relates

@jayaddison jayaddison requested a review from picnixz March 22, 2024 09:44
@picnixz
Copy link
Member

picnixz commented Mar 22, 2024

Ah, no, these comments are to structure the list itself. The list must only contain module names not file names.

@picnixz picnixz closed this Mar 22, 2024
@picnixz picnixz removed their request for review March 22, 2024 09:56
@jayaddison
Copy link
Contributor Author

Ah, silly me! Makes sense. Thanks.

@jayaddison jayaddison deleted the linting/mypy-remove-resolved-overrides branch March 22, 2024 10:04
@jayaddison
Copy link
Contributor Author

Low priority: could we make these comments more different to filenames? (section headings, or similar)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants