Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CVE URL #13006

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update CVE URL #13006

merged 1 commit into from
Oct 11, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 11, 2024

Subject:

Feature or Bugfix

  • Bugfix?

Purpose

Detail

  • This PR updates the URL for the CVE role.

Relates

felixxm added a commit to felixxm/django that referenced this pull request Oct 11, 2024
Sphinx 8.1 added :cve: role, so there is no need to define it in Django:
- sphinx-doc/sphinx#11781

This also changes used URL to the one used by Python and soonish to be
used by Sphinx itself:
- sphinx-doc/sphinx#13006
sarahboyce pushed a commit to django/django that referenced this pull request Oct 11, 2024
Sphinx 8.1 added :cve: role, so there is no need to define it in Django:
- sphinx-doc/sphinx#11781

This also changes used URL to the one used by Python and soonish to be
used by Sphinx itself:
- sphinx-doc/sphinx#13006
@AA-Turner
Copy link
Member

@hugovk should this go into 8.1.1 for Pillow's purposes? Otherwise it would be 8.2, which will probably be several weeks' time.

A

@@ -54,7 +54,7 @@
'image_loading': 'link',
'embed_stylesheet': False,
'cloak_email_addresses': True,
'cve_base_url': 'https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-',
'cve_base_url': 'https://www.cve.org/CVERecord?id=CVE-',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a docutils variable rather than a sphinx one?
Docutils variables are only really their for compatibility, a sphinx user should never have to deal with them

@hugovk
Copy link
Contributor Author

hugovk commented Oct 11, 2024

@hugovk should this go into 8.1.1 for Pillow's purposes? Otherwise it would be 8.2, which will probably be several weeks' time.

If you're doing an 8.1.1, it'd be nice to include it, but absolutely rush at all for us. Thanks!

@AA-Turner AA-Turner merged commit 58263e2 into sphinx-doc:master Oct 11, 2024
23 checks passed
@AA-Turner AA-Turner added this to the 8.1.x milestone Oct 11, 2024
@hugovk hugovk deleted the cve-url branch October 11, 2024 22:32
@hugovk
Copy link
Contributor Author

hugovk commented Oct 11, 2024

If you're doing an 8.1.1, it'd be nice to include it, but absolutely rush at all for us.

Sorry, I of course meant "absolutely no rush at all for us" 😅

@AA-Turner
Copy link
Member

And yet rush I did: Sphinx 8.1.1 has been released.

A

sarahboyce pushed a commit to django/django that referenced this pull request Oct 14, 2024
Sphinx 8.1 added :cve: role, so there is no need to define it in Django:
- sphinx-doc/sphinx#11781

This also changes used URL to the one used by Python and soonish to be
used by Sphinx itself:
- sphinx-doc/sphinx#13006

Backport of 263f731 from main.
felixxm added a commit to felixxm/cpython that referenced this pull request Oct 14, 2024
j-the-ripper pushed a commit to j-the-ripper/django that referenced this pull request Oct 15, 2024
Sphinx 8.1 added :cve: role, so there is no need to define it in Django:
- sphinx-doc/sphinx#11781

This also changes used URL to the one used by Python and soonish to be
used by Sphinx itself:
- sphinx-doc/sphinx#13006
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants