Fix blank URL_ROOT #4916
Merged
Fix blank URL_ROOT #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.7 #4916 +/- ##
=======================================
Coverage 81.96% 81.96%
=======================================
Files 282 282
Lines 37594 37594
Branches 5829 5829
=======================================
Hits 30814 30814
Misses 5477 5477
Partials 1303 1303Continue to review full report at Codecov.
|
tk0miya
requested changes
May 2, 2018
ghost
changed the base branch from
pathto doesn't expand in non-HTML templates so the workaround involves expanding it in the HTML file and passing it as a data attribute to the script.
tk0miya
approved these changes
May 15, 2018
|
Merged. Thank you for your contribution! |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
May 15, 2018
tk0miya
added a commit
that referenced
this pull request
May 18, 2018
ix5
added a commit
to ix5/isso
that referenced
this pull request
Mar 28, 2022
A few things got refactored in sphinx, especially for 4.x. Therefore, use provided helpers. As a reference for the future, always look at what the "basic" sphinx theme (bundled as `sphinx/themes/basic`) does. See: - sphinx-doc/sphinx@a957d6f710 - sphinx-doc/sphinx#4916 - sphinx-doc/sphinx#4915 - readthedocs/sphinx_rtd_theme#1021
ix5
added a commit
to ix5/isso
that referenced
this pull request
Mar 28, 2022
A few things got refactored in sphinx, especially for 4.x. Therefore, use provided helpers. As a reference for the future, always look at what the "basic" sphinx theme (bundled as `sphinx/themes/basic`) does. See: - sphinx-doc/sphinx@a957d6f710 - sphinx-doc/sphinx#4916 - sphinx-doc/sphinx#4915 - readthedocs/sphinx_rtd_theme#1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix blank URL_ROOT
Feature or Bugfix
Purpose
pathto doesn't expand in non-HTML templates so the workaround involves
expanding it in the HTML file and passing it as a data attribute to
the script.
Detail
Relates