Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column expression rewrite #37

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

Sevenannn
Copy link

@Sevenannn Sevenannn commented Jan 3, 2025

🗣 Description

Fix the logic for column expression rewrite when table name same as column name. Also added a test case to ensure the validity of the change.

🔨 Related Issues

🤔 Concerns

@Sevenannn Sevenannn changed the title Fix column expression rewrite fix: column expression rewrite Jan 3, 2025
@Sevenannn Sevenannn marked this pull request as ready for review January 3, 2025 21:42
@Sevenannn Sevenannn requested a review from a team January 3, 2025 21:42
@phillipleblanc phillipleblanc merged commit 4e65b2b into spiceai-43 Jan 4, 2025
17 of 20 checks passed
@phillipleblanc phillipleblanc deleted the qianqian/fix branch January 4, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants