Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Block picker #569

Closed
leevigraham opened this issue May 4, 2022 · 13 comments
Closed

[FR] Block picker #569

leevigraham opened this issue May 4, 2022 · 13 comments
Milestone

Comments

@leevigraham
Copy link
Contributor

Having some kind of block picker with icons and descriptions would be a welcomed addition.

I'm not sure how this could work with nested blocks.

In our current build we're overriding the NEO css so the "Add a block" button is always shown:

image

Example from Webflow

image

Example from Vizy

image

@bryantAXS
Copy link

Agree 100% - I would love this.

@ttempleton
Copy link
Contributor

I'm pretty keen to add this soon - just wondering if anyone has feedback on whether the choice between this and the existing buttons should be set at the plugin or field level?

@leevigraham
Copy link
Contributor Author

My Vote: Plugin Level: Content admins don't need two UI's

@ttempleton ttempleton added this to the 3.6.0 milestone Jan 6, 2023
@leevigraham
Copy link
Contributor Author

leevigraham commented Jan 16, 2023

@ttempleton I just took a look at the main branch, nice work getting this in! It cuts down on the UI noise a great deal.

A little bit of feedback. The icons / buttons need to be way smaller. Here's a couple of mockups:

Screenshot 2023-01-16 at 3 08 50 pm
Screenshot 2023-01-16 at 3 04 54 pm

I think I actually prefer the list style as its much easier to scan down the list.

For reference this is what I'm seeing:

image

@leevigraham
Copy link
Contributor Author

@ttempleton Looks like you're using the Granish menu javascript and overriding a lot of styles. Pairing back your customisations and adding a few tweaks we get something like:

Screenshot 2023-01-16 at 3 36 25 pm

@Mathias-Syversen
Copy link

This looks really promising!

Having the option to override the template that prints out this list would be amazing.
We could have huge custom pickers with screenshots and design or just a simple list.

Neo could then come with a simple list / grid by default.

Kinda like what Matrix Field Preview does, but maybe not as big, custom / override template for this would open the door to make something similar:
screenshot-16

@ttempleton
Copy link
Contributor

Thanks for the feedback!

@leevigraham regarding the list style, I've just made some changes to replace the useNewBlockGrid setting with newBlockButtonType, which has the following options:

  • 'matrix': the traditional, Matrix-inspired buttons/dropdowns;
  • 'grid': the Vizy-inspired grid as you've already seen it;
  • 'list': styled similarly to what's shown in your last screenshot.

Regarding the grid icon size, I'll have a chat to our dev team about that when I get a chance on Thursday and will update here.

@Mathias-Syversen I think allowing custom new block button/menu styles is a great idea! I'm not sure if it's feasible in the short term, since all of the new block buttons/menus are currently rendered in JavaScript, but it's something I'd definitely like to do in the future.

@bryantAXS
Copy link

I love seeing all this chatter and movement happening here! Thanks for the great work folks :)

@leevigraham
Copy link
Contributor Author

I'm with @Mathias-Syversen,

The modal looks great and gives users much more information. We have all the elements to build that (image / icon, title, and description).

I would love to see this as an option…

@ttempleton
Copy link
Contributor

I've just made some changes to:

  • make the icons smaller on the grid, as suggested;
  • change the name of the setting from newBlockButtonType to newBlockMenuStyle;
  • change the 'matrix' option to 'classic'.

Sorry about the repeated setting name changes 😅

Happy to hear any other feedback on how the grid/list styles could be improved. Regarding adding the ability to customise/override the new block menu - please feel free to open a new issue for that.

@ttempleton
Copy link
Contributor

I've just released Neo 3.6.0 with the grid/list menu styles.

@Mathias-Syversen
Copy link

The icons seems to be saved in project config as a relation to an asset?
This wont work when pushing to production. Also activating admin changes to add the icons in production is a no go.
How is this supposed to work?

@rauwebieten
Copy link

Having the same issue as Mathias-Syversen

This feature is not working in a setup with a local development combined with a production environment where 1. the development assets are not available, and 2. the admin changes are not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants