Clean code, and upgrade dependencies #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <[email protected]>
Comment on lines
+25
to
+26
| // TODO: is there a reason for this to be exposed? and inside of config? | ||
| ReloadExternalProcess func() error |
There was a problem hiding this comment.
I added this in a long time ago. We were importing the github.com/spiffe/spiffe-helper/pkg/sidecar into our go program to save certificates to disk and call a function to reload process instead of sending a signal.
There was a problem hiding this comment.
do you think that code is still in use?
is something we can remove in a near future?
There was a problem hiding this comment.
I think so, we ended up not using it.
faisal-memon
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcos Yacob [email protected]