Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorHandlerMiddleware can't be easily injected without autowire due to bool param #295

Closed
vvval opened this issue Sep 17, 2020 · 0 comments · Fixed by #296
Closed

ErrorHandlerMiddleware can't be easily injected without autowire due to bool param #295

vvval opened this issue Sep 17, 2020 · 0 comments · Fixed by #296
Assignees
@vvval

Comments

@vvval
Copy link
Member

vvval commented Sep 17, 2020

ErrorHandlerMiddleware can't be easily injected without autowire due to bool param:

 [Spiral\Core\Exception\Container\ArgumentException]                                                         
 Unable to resolve 'suppressErrors' argument in 'Spiral\Http\Middleware\ErrorHandlerMiddleware::__construct'

I suggest to replace it with an instance of wrapper class
@vvval vvval self-assigned this Sep 17, 2020
vvval pushed a commit that referenced this issue Sep 17, 2020
#295 add supressError wrapper
e552b62
@vvval vvval linked a pull request Sep 17, 2020 that will close this issue
#295 add supressError wrapper #296
Merged
vvval pushed a commit that referenced this issue Sep 17, 2020
#295 fix interface inheritance
8d96b70
@SerafimArts SerafimArts mentioned this issue Sep 17, 2020
Merged
SerafimArts added a commit that referenced this issue Sep 17, 2020
@SerafimArts
Merge pull request #296 from spiral/pr/295-error_handler_middleware_s…
993590f 
…upressing

#295 add supressError wrapper
SerafimArts added a commit that referenced this issue Sep 17, 2020
@SerafimArts
Add #295 issue into changelog
ed7a977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvval vvval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#295 add supressError wrapper spiral/framework
1 participant
@vvval