Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/condition compositions #13

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Conversation

vvval
Copy link
Member

@vvval vvval commented Aug 6, 2020

  • fix code style issues
  • add any, none conditions

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #13 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     95.52%   95.73%   +0.20%     
- Complexity      262      274      +12     
============================================
  Files            25       28       +3     
  Lines           492      516      +24     
============================================
+ Hits            470      494      +24     
  Misses           22       22              
Impacted Files Coverage Δ Complexity Δ
src/AbstractChecker.php 94.11% <ø> (ø) 6.00 <0.00> (ø)
src/CallableRule.php 100.00% <ø> (ø) 10.00 <0.00> (ø)
src/Checker/ImageChecker.php 96.29% <ø> (ø) 14.00 <0.00> (ø)
src/CheckerRule.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/ValidationProvider.php 97.61% <ø> (ø) 17.00 <0.00> (ø)
src/Checker/AddressChecker.php 100.00% <100.00%> (ø) 16.00 <0.00> (ø)
src/Checker/MixedChecker.php 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
src/Condition/AnyOfCondition.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/Condition/Compositor.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Condition/NoneOfCondition.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c646fe4...6aa796e. Read the comment docs.

@vvval vvval linked an issue Aug 6, 2020 that may be closed by this pull request
@vvval vvval requested review from wolfy-j and SerafimArts and removed request for wolfy-j August 6, 2020 09:30
@SerafimArts SerafimArts merged commit 51b6ea8 into master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conditions composition like any or none of set
2 participants