Feature/poetry #390
Merged
Feature/poetry #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-wu
requested review from
arctan5x,
GordonWang,
jmeixensperger and
lephino
as code owners
li-wu
force-pushed
the
feature/poetry
branch
15 times, most recently
from
8cdf680
to
4778b2a
Compare
li-wu
commented
May 7, 2020
| @echo 'Installing test requirements' | ||
| docker exec -i ${EVENTGEN_TEST_IMAGE} /bin/sh -c "pip3 install --upgrade pip;pip3 install -r $(shell pwd)/requirements.txt" | ||
| @echo 'Installing test dependencies' | ||
| docker exec -i ${EVENTGEN_TEST_IMAGE} /bin/sh -c "pip3 install poetry;poetry config virtualenvs.create false;poetry install --no-root" |
There was a problem hiding this comment.
install poetry and disable poetry to use virtualenv so that the following tests can find dependent packages. Check here.
li-wu
commented
May 7, 2020
| @@ -0,0 +1,1211 @@ | |||
| [[package]] | |||
There was a problem hiding this comment.
The poetry.lock file is used for keep consistent environment for dependencies.
li-wu
commented
May 7, 2020
| httplib2 = "^0.17.2" | ||
| uuid = "^1.30" | ||
|
|
||
| [tool.poetry.dev-dependencies] |
There was a problem hiding this comment.
Dev dependencies are in a separate section which is more clear.
| ``` | ||
| Eventgen uses [Poetry](https://github.com/python-poetry/poetry) to manage and build. Install `Poetry` first: | ||
| ``` | ||
| curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python |
There was a problem hiding this comment.
Can you also add instructions for installing poetry via pip?
added 2 commits
May 9, 2020 06:35
li-wu
commented
May 8, 2020
| @@ -1 +0,0 @@ | |||
| {"version": "7.1.0"} | |||
There was a problem hiding this comment.
The version.json is now deleted. We use the version in pyproject.toml as single source.
li-wu
commented
May 8, 2020
| @@ -48,32 +48,50 @@ def flush(self, q): | |||
| # This may cause the file exceed the maxFileBytes a little bit but will greatly improve the performance | |||
| try: | |||
| for metamsg in q: | |||
| msg = metamsg.get('_raw') | |||
| msg = metamsg.get("_raw") | |||
There was a problem hiding this comment.
The changes in this file are made by make format-all.
GordonWang
approved these changes
May 11, 2020
jmeixensperger
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt
poetryto manage build/dependencies/dev-dependencies/publish. Props:pyproject.tomlto replacerequirements.txt,MANIFEST.in,setup.pyandsetup.cfg.poetryin a consistent way.