-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS-3302: Initial Project Setup #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled directly from previous host repository, UtilityBelt-iOS.
Generated by 🚫 Danger |
lquigley
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
https://spothero.atlassian.net/browse/IOS-3302
Description
This PR sets up the project by pulling the
UtilityBeltData
code from https://github.com/spothero/UtilityBelt-iOS and placing it in its own package calledCoreDataHero
.Similarly, all foundational code is also a direct pull-over from
UtilityBelt-iOS
, updating names as needed.Besides name changes, the only changes that I manually performed were:
11
back down to10
, since this package doesn't use CombineRunScriptHelper.xcodeproj
for now. It appears to not be working correctly at the moment, so I'll create a separate ticket to get SwiftLint running during local development.