Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-3302: Initial Project Setup #1

Merged
merged 18 commits into from
Oct 7, 2021
Merged

IOS-3302: Initial Project Setup #1

merged 18 commits into from
Oct 7, 2021

Conversation

khaptonstall
Copy link
Contributor

Issue Link
https://spothero.atlassian.net/browse/IOS-3302

Description
This PR sets up the project by pulling the UtilityBeltData code from https://github.com/spothero/UtilityBelt-iOS and placing it in its own package called CoreDataHero.

Similarly, all foundational code is also a direct pull-over from UtilityBelt-iOS, updating names as needed.

Besides name changes, the only changes that I manually performed were:

  • Updating the minimum supported iOS version from 11 back down to 10, since this package doesn't use Combine
  • Changed project description in the README
  • Removed the RunScriptHelper.xcodeproj for now. It appears to not be working correctly at the moment, so I'll create a separate ticket to get SwiftLint running during local development.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

3 Messages
📖 Formatted with SwiftFormat v0.48.11.
📖 Linted with SwiftLint v0.41.0.
📖 👋 👋 Great job!

Generated by 🚫 Danger

@khaptonstall khaptonstall marked this pull request as ready for review October 6, 2021 22:46
@khaptonstall khaptonstall requested a review from a team October 6, 2021 22:47
@lquigley lquigley self-assigned this Oct 7, 2021
@khaptonstall khaptonstall merged commit 3fe8a54 into main Oct 7, 2021
@khaptonstall khaptonstall deleted the project-setup branch October 7, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants