Validate only additional parts necessary #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e line_item's quantity (instead of the entire quantity).
| @@ -3,14 +3,17 @@ module Stock | |||
| # Overridden from spree core to make it also check for assembly parts stock | |||
| class AvailabilityValidator < ActiveModel::Validator | |||
| def validate(line_item) | |||
| unit_count = line_item.inventory_units.size | |||
| return if unit_count >= line_item.quantity | |||
|
|
|||
There was a problem hiding this comment.
I don't think this will work. I think this is what's needed...
unit_count = line_item.inventory_units.size
parts_total = line_item.parts.to_a.sum { |v| line_item.count_of(v) } * line_item.quantity
return if unit_count >= parts_total
Merged
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AvailabilityValidator seems to be validating for the entire quantity of the line_item instead of the quantity being added to the line_item (as spree's does). The proposed AvailabilityValidator change validates only the availability of additional parts needed to fulfill changes to the line_item's quantity.