Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logback OnErrorConsoleStatusListener is not registered when using a custom logback-spring.xml #43822

Closed
nosan opened this issue Jan 14, 2025 · 1 comment
Closed

Logback OnErrorConsoleStatusListener is not registered when using a custom logback-spring.xml #43822

nosan opened this issue Jan 14, 2025 · 1 comment
Labels
type: task A general task

Comments

@nosan
Copy link
Contributor

nosan commented Jan 14, 2025 •
edited
Loading

Registration of OnErrorConsoleStatusListener was added in the LogbackLoggingSystem.loadDefaults method (PR: #43575), similar to how the OnConsoleStatusListener is registered when logback.debug is enabled.

However, I’m not sure if adding it only in loadDefaults method was the right approach, as the listener won’t be registered when a custom logback-spring.xml file is used.

Should it also be registered in the LogbackLoggingSystem.loadConfiguration method?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 14, 2025
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 21, 2025
@philwebb philwebb added this to the 3.5.x milestone Jan 21, 2025
@philwebb philwebb added type: task A general task and removed type: bug A general bug labels Jan 21, 2025
nosan added a commit to nosan/spring-boot that referenced this issue Jan 22, 2025
@nosan
Register Logback OnErrorConsoleStatusListener when using custom Logba…
27ad19f 
…ck file

Prior to this commit, OnErrorConsoleStatusListener was not registered
for a custom Logback configuration file.

This commit registers OnErrorConsoleStatusListener when the Logback
configuration is loaded from a custom Logback file that does
not include any StatusListener.

See spring-projectsgh-43822

Signed-off-by: Dmytro Nosan <[email protected]>
@nosan nosan mentioned this issue Jan 22, 2025
Closed
nosan added a commit to nosan/spring-boot that referenced this issue Jan 23, 2025
@nosan
Register Logback OnErrorConsoleStatusListener when using custom Logba…
653fd2a 
…ck file

Prior to this commit, OnErrorConsoleStatusListener was not registered
for a custom Logback configuration file.

This commit registers OnErrorConsoleStatusListener when the Logback
configuration is loaded from a custom Logback file that does
not include any StatusListener.

See spring-projectsgh-43822

Signed-off-by: Dmytro Nosan <[email protected]>
nosan added a commit to nosan/spring-boot that referenced this issue Jan 26, 2025
@nosan
Register Logback OnErrorConsoleStatusListener when using custom Logba…
32e557d 
…ck file

Prior to this commit, OnErrorConsoleStatusListener was not registered
for a custom Logback configuration file.

This commit registers OnErrorConsoleStatusListener when the Logback
configuration is loaded from a custom Logback file.

See spring-projectsgh-43822

Signed-off-by: Dmytro Nosan <[email protected]>
nosan added a commit to nosan/spring-boot that referenced this issue Jan 26, 2025
@nosan
Register Logback OnErrorConsoleStatusListener when using custom Logba…
2cd01fa 
…ck file

Prior to this commit, OnErrorConsoleStatusListener was not registered
for a custom Logback configuration file.

This commit registers OnErrorConsoleStatusListener when the Logback
configuration is loaded from a custom Logback file that does
not include any StatusListener.

See spring-projectsgh-43822

Signed-off-by: Dmytro Nosan <[email protected]>
@nosan
Copy link
Contributor Author

nosan commented Jan 29, 2025 •
edited
Loading

Superseded by #43931

@nosan nosan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
@wilkinsona wilkinsona removed this from the 3.5.x milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philwebb @wilkinsona @nosan @spring-projects-issues