Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoHash toString conversion #3001

Closed
sothawo opened this issue Nov 8, 2024 · 0 comments · Fixed by #3002
Closed

Fix GeoHash toString conversion #3001

sothawo opened this issue Nov 8, 2024 · 0 comments · Fixed by #3002
Assignees
@sothawo
Labels
type: bug A general bug
Milestone
5.4 GA (2024.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Nov 8, 2024

In the org.springframework.data.elasticsearch.utils.geohash.Geohash#toLatLon() method the code currently uses

String.format("%f,%f", point.getLat(), point.getLon());

to convert a geopoint to a String containing lat,lon values. This produces a wrong string when running in a Locale where the decimal separator is a comma (germany for example). Need to be fixed to use a defined Locale in formatting
@sothawo sothawo added the type: bug A general bug label Nov 8, 2024
@sothawo sothawo self-assigned this Nov 8, 2024
@sothawo sothawo mentioned this issue Nov 8, 2024
Merged
@sothawo sothawo closed this as completed in 7f5bfff Nov 8, 2024
@sothawo sothawo added this to the 5.4 GA (2024.1.0) milestone Nov 8, 2024
sothawo added a commit that referenced this issue Nov 8, 2024
@sothawo
fix geohash conversion
d0020be 
Original Pull Request #3002
Closes #3001

(cherry picked from commit 7f5bfff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: bug A general bug
Projects
None yet
Milestone
5.4 GA (2024.1.0)
Development

Successfully merging a pull request may close this issue.

fix geohash conversion sothawo/spring-data-elasticsearch
1 participant
@sothawo