Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a NativeDetector utility class #25795

Closed
sdeleuze opened this issue Sep 21, 2020 · 4 comments
Closed

Introduce a NativeDetector utility class #25795

sdeleuze opened this issue Sep 21, 2020 · 4 comments
Assignees
@sdeleuze
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.3.4

Comments

@sdeleuze
Copy link
Contributor

If oracle/graal#2594 get fixed in time we should probably reintroduce GraalDetector renamed to NativeDetector for a wider scope (could be useful for Project Leyden). It was removed via 806eb5c.
@sdeleuze sdeleuze added this to the 5.3 GA milestone Sep 21, 2020
@sdeleuze sdeleuze self-assigned this Sep 21, 2020
@sdeleuze
Copy link
Contributor Author

@jhoeller I got the confirmation the related GraalVM issue will fixed in 20.3 but not in time for our 5.3 GA, could we create a 5.3.1 milestone and target it for this issue resolution?

@jhoeller jhoeller modified the milestones: 5.3 GA, 5.3.1 Oct 26, 2020
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Oct 26, 2020
@sdeleuze
Copy link
Contributor Author

sdeleuze commented Nov 2, 2020

Blocked on oracle/graal#2594.

@sdeleuze sdeleuze added the status: blocked An issue that's blocked on an external project change label Nov 2, 2020
@sdeleuze sdeleuze mentioned this issue Nov 3, 2020
Closed
@sdeleuze sdeleuze modified the milestones: 5.3.1, 5.3.2 Nov 8, 2020
@sdeleuze sdeleuze modified the milestones: 5.3.2, 5.x Backlog Nov 16, 2020
@sdeleuze
Copy link
Contributor Author

Sadly the related GraalVM issue did not make it in 20.3.0 so we will have to wait 21.0.0. I asked for early inclusion in order to give us the time to test and provide feedback.

@sdeleuze sdeleuze modified the milestones: 5.x Backlog, 5.3.3 Jan 5, 2021
@sdeleuze sdeleuze removed the status: blocked An issue that's blocked on an external project change label Jan 5, 2021
@sdeleuze
Copy link
Contributor Author

sdeleuze commented Jan 5, 2021

GraalVM now allows to use such utility method to detect native image runtime when the -H:+InlineBeforeAnalysis flag is used, which will be enabled by default in Spring Native. See oracle/graal#2594 (comment) related comment.

@sdeleuze sdeleuze mentioned this issue Jan 5, 2021
Closed
@sdeleuze sdeleuze modified the milestones: 5.3.3, 5.3.4 Jan 11, 2021
@sdeleuze sdeleuze mentioned this issue Jan 15, 2021
Closed
christophstrobl added a commit to spring-projects/spring-data-commons that referenced this issue Feb 16, 2021
@christophstrobl
Use NativeDetector.inNativeImage() instead of manual property check.
adc1d46 
Relates to: spring-projects/spring-framework#25795
@christophstrobl christophstrobl mentioned this issue Feb 16, 2021
Closed
This was referenced Mar 11, 2021
Closed
Closed
Open
Open
Closed
Open
Open
Merged
Open
Open
Open
Closed
Merged
Merged
Closed
Open
Open
Merged
Open
Open
Merged
Open
Open
Merged
Open
Open
Open
Open
Open
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sdeleuze @lxbzmy
Introduce a NativeDetector utility class
34fe826 
With the introduction of the -H:+InlineBeforeAnalysis native image
compiler flag in GraalVM 21.0.0, it is now possible to use an utility method and get code
removal at build time.

This flag will be enabled as of Spring Native 0.9.0.

closes spring-projectsgh-25795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.4
Development

No branches or pull requests
2 participants
@sdeleuze @jhoeller