Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 10 Support #26123

Closed
rstoyanchev opened this issue Nov 19, 2020 · 2 comments
Closed

Jetty 10 Support #26123

rstoyanchev opened this issue Nov 19, 2020 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3.4

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Nov 19, 2020 •
edited
Loading

Jetty 10 includes major changes of its WebSocket API as well as other changes to fairly prominent API types (e.g. access to headers via HttpFields). For 5.3.x we need to support 9.4.x and 10.x side by side.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 19, 2020
@rstoyanchev rstoyanchev added this to the 5.x Backlog milestone Nov 19, 2020
@rstoyanchev rstoyanchev self-assigned this Nov 19, 2020
@rstoyanchev rstoyanchev modified the milestones: 5.x Backlog, 5.3.3 Dec 7, 2020
@rstoyanchev
Copy link
Contributor Author

After some experimentation, currently for Jetty 10 it is expected to extend JettyWebSocketServlet and use a JettyWebSocketCreator argument passed into a protected method to register WebSocket endpoints. That alone won't help us. It is possible to do what JettyWebSocketServlet does with all public classes but some are in internal packages.

A better option would be to have a dedicated SPI for programmatic upgrades. There is now an issue to track that jetty/jetty.project#5866 and once available we'll make use of it.

@rstoyanchev rstoyanchev modified the milestones: 5.3.3, 5.3.4 Jan 8, 2021
@wilkinsona wilkinsona mentioned this issue Jan 19, 2021
Closed
@rstoyanchev rstoyanchev changed the title Jetty 10 WebSocket Support Jetty 10 Support Jan 21, 2021
@rstoyanchev
Copy link
Contributor Author

Support for Jetty 10 is now in master. I've done basic testing with:

  • spring-websocket server and client
  • spring-webflux server and client
  • Jetty reactive HTTP client.

@sync-by-unito sync-by-unito bot mentioned this issue Feb 17, 2021
Merged
This was referenced Mar 7, 2021
Open
Closed
Closed
Open
Open
Closed
Open
Open
Merged
Open
Open
Open
Closed
Merged
Merged
@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
This was referenced Mar 15, 2021
Open
Open
Merged
Open
Open
Merged
Open
Open
Merged
Open
Open
Open
Open
Open
poutsma added a commit that referenced this issue Jan 26, 2023
@poutsma
Support Jetty 10 in JettyClientHttpRequest
21c3d4f 
Though Jetty 10 was previously supported in the JettyClientHttpResponse,
this commit ensures support in the JettyClientHttpRequest.

Closes gh-29867
See gh-26123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.4
Development

No branches or pull requests
1 participant
@rstoyanchev