Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleEvaluationContext should disable array allocation #28808

Closed
quaff opened this issue Jul 13, 2022 · 0 comments
Closed

SimpleEvaluationContext should disable array allocation #28808

quaff opened this issue Jul 13, 2022 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.0-RC2

Comments

@quaff
Copy link
Contributor

quaff commented Jul 13, 2022 •
edited by sbrannen
Loading

The Javadoc for SimpleEvaluationContext states that it is:

tailored to support only a subset of the SpEL language syntax, e.g. excluding references to Java types, constructors, and bean references.

Since array allocation is a special kind of constructor we should also disable array allocation in order to adhere to the contract of SimpleEvaluationContext.

This may be a breaking change for some users. Consequently, this change should likely only be made in Spring Framework 6.0.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 13, 2022
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jul 13, 2022
@sbrannen sbrannen added this to the 6.0.0-M6 milestone Jul 13, 2022
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 13, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M6, 6.0.0-RC1 Aug 29, 2022
@jhoeller jhoeller modified the milestones: 6.0.0-RC1, 6.0.0-RC2 Oct 11, 2022
@jhoeller jhoeller self-assigned this Oct 18, 2022
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Aug 14, 2024
@github-actions github-actions bot mentioned this issue Aug 14, 2024
Closed
sbrannen pushed a commit that referenced this issue Aug 14, 2024
@jhoeller @sbrannen
Disable array allocation in case of no constructor resolution
f44d13c 
See gh-28808
Closes gh-33386

(cherry picked from commit a3a48a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC2
Development

No branches or pull requests
4 participants
@sbrannen @quaff @jhoeller @spring-projects-issues