Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MvcRequestMatcher construction #13562

Open
Tracked by #13568
jzheaux opened this issue Jul 18, 2023 · 1 comment · Fixed by #13857 · May be fixed by #16208
Open
Tracked by #13568

Simplify MvcRequestMatcher construction #13562

jzheaux opened this issue Jul 18, 2023 · 1 comment · Fixed by #13857 · May be fixed by #16208
Assignees
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 18, 2023

Constructing an MvcRequestMatcher can be confusing since it's unclear where to obtain a HandlerMappingIntrospector from.

Spring Security could publish a prototype bean like so to make that easier:

@Bean 
@Scope("prototype")
MvcRequestMatcher.Builder mvcRequestMatcherBuilder(HandlerMappingIntrospector introspector) {
    return new MvcRequestMatcher.Builder(introspector);
}
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jul 18, 2023
@jzheaux jzheaux self-assigned this Sep 19, 2023
@jzheaux jzheaux changed the title Consider simplifying MvcRequestMatcher construction Simplify MvcRequestMatcher construction Sep 19, 2023
jzheaux added a commit to jzheaux/spring-security that referenced this issue Oct 12, 2023
jzheaux added a commit that referenced this issue Oct 12, 2023
@jzheaux jzheaux moved this to Done in Spring Security Team Oct 17, 2023
@jzheaux jzheaux added in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 17, 2023
@jzheaux
Copy link
Contributor Author

jzheaux commented Nov 17, 2023

Due to #13794, this has been reopened to give us more time to assess the right solution.

@jzheaux jzheaux reopened this Nov 17, 2023
jzheaux added a commit to jzheaux/spring-checkpoint-restore-smoke-tests that referenced this issue May 20, 2024
sdeleuze pushed a commit to spring-projects/spring-lifecycle-smoke-tests that referenced this issue May 23, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Dec 2, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Dec 2, 2024
@jzheaux jzheaux linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
Status: Done
1 participant