Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitializeUserDetailsBeanManagerConfigurer should use Constructor Injection #14691

Closed
rwinch opened this issue Mar 5, 2024 · 0 comments · Fixed by #14766
Closed

InitializeUserDetailsBeanManagerConfigurer should use Constructor Injection #14691

rwinch opened this issue Mar 5, 2024 · 0 comments · Fixed by #14766
Assignees
@sjohnr
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Mar 5, 2024

The InitializeUserDetailsBeanManagerConfigurer should inject the PasswordEncoder into the constructor of DaoAuthenticationProvider to prevent the unnecessary execution of PasswordEncoderFactories.createDelegatingPasswordEncoder() which causes issues for users with FIPS compliant JDKs. See #14670
@rwinch rwinch added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement in: core An issue in spring-security-core and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 5, 2024
@rwinch rwinch mentioned this issue Mar 5, 2024
Closed
kse-music added a commit to kse-music/spring-security that referenced this issue Mar 17, 2024
@kse-music
inject PasswordEncoder into DaoAuthenticationProvider constructor
e602fb0 
Closes spring-projectsgh-14691
@kse-music kse-music mentioned this issue Mar 17, 2024
Merged
kse-music added a commit to kse-music/spring-security that referenced this issue Apr 6, 2024
@kse-music
inject PasswordEncoder into DaoAuthenticationProvider constructor
2e64012 
Closes spring-projectsgh-14691
sjohnr pushed a commit that referenced this issue Apr 8, 2024
@kse-music @sjohnr
inject PasswordEncoder into DaoAuthenticationProvider constructor
75197ca 
Closes gh-14691
@sjohnr sjohnr self-assigned this Apr 8, 2024
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
2 participants
@rwinch @sjohnr